environment: Don't use actor if an ease callback destroys it

An actor ease callback could destroy the actor, in such case we should do not
touch the actor anymore.

So, before calling the callback, reset restore the easing state and don't
perform any further action with it.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1507

diff --git a/js/ui/environment.js b/js/ui/environment.js
index 60d73d9ccb83e905dd8c3320560e1bff71059ac1..0c291b0a20d6f9da499021a0350b04301d49ebfc 100644 (file)
--- a/js/ui/environment.js
+++ b/js/ui/environment.js
@@ -117,6 +117,7 @@ function _easeActor(actor, params) {
     animatedProps.forEach(p => actor.remove_transition(p));
 
     actor.set(params);
+    actor.restore_easing_state();
 
     if (callback) {
         let transition = actor.get_transition(animatedProps[0]);
@@ -126,8 +127,6 @@ function _easeActor(actor, params) {
         else
             callback(true);
     }
-
-    actor.restore_easing_state();
 }
 
 function _easeActorProperty(actor, propName, target, params) {